Allow accessor properties in ambient contexts when targeting ES5#61927
Merged
RyanCavanaugh merged 3 commits intomainfrom Jun 25, 2025
Merged
Allow accessor properties in ambient contexts when targeting ES5#61927RyanCavanaugh merged 3 commits intomainfrom
accessor properties in ambient contexts when targeting ES5#61927RyanCavanaugh merged 3 commits intomainfrom
Conversation
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Allow
Allow Jun 23, 2025
accessor properties in .d.ts even when targeting ES5accessor properties in ambient contexts when targeting ES5
RyanCavanaugh
requested changes
Jun 24, 2025
Member
RyanCavanaugh
left a comment
There was a problem hiding this comment.
Fix your line endings in checker.ts to match the rest of the file
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Contributor
Author
Fixed line endings to match CRLF format used throughout checker.ts file. c8adde3 |
jakebailey
approved these changes
Jun 24, 2025
gabritto
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where TypeScript incorrectly disallowed
accessorproperties in ambient contexts (.d.tsfiles,declare class,declare module, etc.) when targeting ES5.Problem
Previously, TypeScript would error on
accessorproperties in all contexts when targeting ES5:This forced consumers of libraries like
@babel/parser(which useaccessorin their.d.tsfiles) to enableskipLibCheckwhen targeting ES5, which is not ideal.Solution
Modified the
checkGrammarPropertyfunction insrc/compiler/checker.tsto exclude ambient contexts from the ES5 accessor restriction:Result
With this fix:
Testing
accessorInAmbientContextES5.tscovering all ambient context scenariosThis change follows the same pattern used elsewhere in TypeScript for handling ES2015+ features in ambient contexts and maintains backward compatibility.
Fixes #61181.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
plugins.dprint.dev/home/REDACTED/work/TypeScript/TypeScript/node_modules/dprint/dprint fmt(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.